Nerves cross-compilation #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noarkhh
force-pushed
the
nerves-crosscompilation
branch
from
b4f0d06
to
5e585d8
Compare
mat-hek
approved these changes
Dec 7, 2023
balins
reviewed
Dec 18, 2023
| def get_current! do | ||
| @spec get_target!() :: name_t | ||
| def get_target!() do | ||
| case {Mix.target(), System.fetch_env("NERVES_APP")} do |
There was a problem hiding this comment.
Looks like this Mix.target() call breaks Elixir releases, as Mix functions are not available in runtime and this apparently is called on startup.
Kernel pid terminated (application_controller) ({application_start_failure,kernel,{{shutdown,{failed_to_start_child,on_load,{on_load_function_failed,'Elixir.Membrane.RTMP.Sink.Native.Nif',{undef,[{'Elixir.Mix',target,[],[]},{'Elixir.Bundlex.Platform','get_target!',0,[{file,"lib/bundlex/platform.ex"},{line,45}]},{'Elixir.Bundlex',family,0,[{file,"lib/bundlex.ex"},{line,51}]},{'Elixir.Bundlex.Helper.PathHelper',fix_slashes,1,[{file,"lib/bundlex/helper/path_helper.ex"},{line,25}]},{'Elixir.Membrane.RTMP.Sink.Native.Nif',load_nif,0,[{file,"lib/membrane_rtmp_plugin/rtmp/sink/native.ex"},{line,1}]},{init,'-run_on_load_handler/2-fun-0-',1,[]}]}}}},{kernel,start,[normal,[]]}}})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes membraneframework/membrane_core#675
closes #106
MIX_TARGETenvironment variable is defined as one of nerves targets use appropriate provided toolchain to cross-compile natives for the specified architecture