Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UX #105

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Improve UX #105

merged 2 commits into from
Apr 27, 2023

Conversation

mat-hek
Copy link
Member

@mat-hek mat-hek commented Apr 27, 2023 •
edited
Loading

@mat-hek mat-hek changed the title Improve errors Improve UX Apr 27, 2023
@mat-hek mat-hek marked this pull request as ready for review April 27, 2023 08:36
@FelonEkonom FelonEkonom self-requested a review April 27, 2023 10:10
FelonEkonom
FelonEkonom requested changes Apr 27, 2023
View reviewed changes
lib/bundlex/toolchain/common/unix.ex Outdated
options = options |> Bunch.listify() |> Enum.map(&"--#{&1}")
{output, 0} = System.cmd("pkg-config", options ++ packages)
String.trim_trailing(output)
System.put_env("PATH", System.get_env("PATH") <> ":/usr/local/bin:/opt/homebrew/bin")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line will fail, if env PATH doesn't exist

@mat-hek
add homebrew installation directories to PATH
222d172 
needed for Livebook desktop, which doesn't have these in PATH
@mat-hek mat-hek merged commit 1958fdd into master Apr 27, 2023
@mat-hek mat-hek deleted the improve-errors branch April 27, 2023 14:03
@mat-hek mat-hek mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelonEkonom FelonEkonom FelonEkonom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mat-hek @FelonEkonom