extract memory llm function call to separate methods #2011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Different LLMs' function call results are different for the same prompt.
So ideally different LLM function call should use different prompts.
Different functionalities (extract entities, facts, etc.) should also use different LLMs because some LLMs are good at handling graph while some other LLMs are good at extracting facts.
In order to support this, we need an LLM implementation abstraction which provides seperate atomic capabilities (extract entites, nodes, facts, etc.) and there own prompts.
This is MR is a prepare MR for the above code refactor.
This MR doesn't change any logic, just extract some atomic functionalities to separate _llm_atomic_fncalls.
The final expectation is, we call llm.atomic_fncall inside memory and graph memory.
How Has This Been Tested?
Checklist:
Maintainer Checklist