-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure batch pipelines #658
Conversation
This reverts commit f082cc2.
@kgpayne the tap-meltanohub fix you added did solve the problem and tests passed https://github.com/meltano/squared/actions/runs/5402924550/jobs/9845025953 expect for the reverse etl jobs that use target-yaml which is too old to support batch right now. I removed all the dev commits and left only slack and cloudwatch as real batch use cases. |
@edgarrmondragon I configured batch with cloudwatch and slack which do need state support. I didnt realize that wasnt supported. The interesting thing is that it seems like the state is still being tracked properly, at least in meltano cloud, I see the first tap-cloudwatch query in the log today says Any idea whats going on? |
@pnadolny13 Ok I didn't realize state was correctly incremented in batch, but looking at the code it seems to be handled correctly. Do let me know if you see anything that feels off with batch 🙏. |
@edgarrmondragon I believe the STATE issue you are thinking of is limited to SQL-based Taps which override the BATCH methods (i.e. to export data using |
@kgpayne that makes sense, thanks! |
Closes #604
I configured all pipelines that could support batch to use it. tap-github and tap-dynamodb use stream maps so I couldnt use batch for those.
I will likely revert a few of these after we see them work in CI since theyre somewhat unnecessary for some cases i.e. tap-snowflake for 3 records.