Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix missing PK in GitLab external tests #944

Merged
merged 3 commits into from
Sep 1, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 1, 2022

This error (a missing PK) was uncovered after #829 landed on main.

Schema generated with https://github.com/edgarrmondragon/jsonschema-infer-tool/ from the example in the GitLab API docs.


📚 Documentation preview 📚: https://meltano-sdk--944.org.readthedocs.build/en/944/

@edgarrmondragon edgarrmondragon self-assigned this Sep 1, 2022
@edgarrmondragon edgarrmondragon force-pushed the ci/fix-gitlab-missing-pk branch from f462784 to 9a81355 Compare September 1, 2022 03:51
@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 1, 2022 03:55
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #944 (f2ee8e9) into main (f0aed5b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files          36       36           
  Lines        3543     3543           
  Branches      712      712           
=======================================
  Hits         2879     2879           
  Misses        489      489           
  Partials      175      175           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title ci: Fix GitLab external tests ci: Fix missing PK in GitLab external tests Sep 1, 2022
@edgarrmondragon edgarrmondragon merged commit ba3f043 into main Sep 1, 2022
@edgarrmondragon edgarrmondragon deleted the ci/fix-gitlab-missing-pk branch September 1, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant