Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use importlib.resources #885

Closed
wants to merge 3 commits into from
Closed

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 4, 2022

Closes #875

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #885 (25f3ab5) into main (eb024bd) will increase coverage by 0.01%.
The diff coverage is 95.00%.

❗ Current head 25f3ab5 differs from pull request most recent head 1776e94. Consider uploading reports for the commit 1776e94 to get more accurate results

@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
+ Coverage   80.31%   80.32%   +0.01%     
==========================================
  Files          34       34              
  Lines        3413     3430      +17     
  Branches      679      682       +3     
==========================================
+ Hits         2741     2755      +14     
- Misses        499      501       +2     
- Partials      173      174       +1     
Impacted Files Coverage Δ
singer_sdk/streams/core.py 80.55% <94.23%> (-0.33%) ⬇️
singer_sdk/helpers/_util.py 66.66% <100.00%> (+16.66%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@edgarrmondragon edgarrmondragon force-pushed the 875-use-importlibresources branch from 01acd00 to 1776e94 Compare August 9, 2022 20:03
@edgarrmondragon edgarrmondragon deleted the 875-use-importlibresources branch December 7, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Recommended way of packaging stream schemas as JSON files should use importlib.resources
1 participant