chore(templates): Remove Poetry version pin for GitHub Actions #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hit an issue in CI with one of these pinned versions. Probably best to grab the latest version with the template
Codecov Report
@@ Coverage Diff @@
## main #826 +/- ##
=======================================
Coverage 82.18% 82.18%
=======================================
Files 37 37
Lines 3621 3621
Branches 722 722
=======================================
Hits 2976 2976
Misses 479 479
Partials 166 166 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
visch
changed the title
edgarrmondragon
requested changes
Jul 17, 2022
...flows/{% if cookiecutter.include_cicd_sample_template == 'GitHub' %}ci_workflow.yml{%endif%}
Show resolved
Hide resolved
...flows/{% if cookiecutter.include_cicd_sample_template == 'GitHub' %}ci_workflow.yml{%endif%}
Show resolved
Hide resolved
…ci_workflow.yml{%endif%}
edgarrmondragon
requested review from
cjohnhanson and
aaronsteers
as code owners
edgarrmondragon
changed the title
edgarrmondragon
changed the title
edgarrmondragon
approved these changes
Sep 29, 2022
|
Thanks for doing the work here @edgarrmondragon :) |
...flows/{% if cookiecutter.include_cicd_sample_template == 'GitHub' %}ci_workflow.yml{%endif%}
Outdated
Show resolved
Hide resolved
...flows/{% if cookiecutter.include_cicd_sample_template == 'GitHub' %}ci_workflow.yml{%endif%}
Outdated
Show resolved
Hide resolved
edgarrmondragon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit an issue in CI with one of these pinned versions. Probably best to grab the latest version with the template.
Pinning is ok, but we should probably add a #TODO to have the developer pull the latest version of Poetry (Or we could do it programmatically with cookiecutter when a new template is made?)
Probably easiest not to pin!