Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove trailing parenthesis from logged version #767

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

Closes #766

@edgarrmondragon edgarrmondragon self-assigned this Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #767 (605b555) into main (e11acd6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #767   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files          34       34           
  Lines        3408     3408           
=======================================
  Hits         2909     2909           
  Misses        499      499           
Impacted Files Coverage Δ
singer_sdk/plugin_base.py 78.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11acd6...605b555. Read the comment docs.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review June 29, 2022 06:41
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) June 29, 2022 16:35
@edgarrmondragon edgarrmondragon disabled auto-merge June 29, 2022 16:45
@edgarrmondragon edgarrmondragon merged commit e1fa4a4 into main Jun 29, 2022
@edgarrmondragon edgarrmondragon deleted the trailing-parenthesis-about branch June 29, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing parenthesis in logged version
1 participant