-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(taps): Allow sort checking to be disabled #730
feat(taps): Allow sort checking to be disabled #730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilkkapeltola - thanks for this contribution! 🙏
This looks good to me on first pass but I'll ask @edgarrmondragon to take a more detailed review.
If there are any tests you could add, those would be appreciated, but I think most of this does flow through existing test cases. I think codecov will give info on which code paths are reached or not, if that's helpful.
Also, if can you add info on manual testing you've run, that's always appreciated as well.
Codecov Report
@@ Coverage Diff @@
## main #730 +/- ##
==========================================
- Coverage 86.84% 85.49% -1.35%
==========================================
Files 34 34
Lines 3383 3386 +3
==========================================
- Hits 2938 2895 -43
- Misses 445 491 +46
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilkkapeltola This looks good to me! We'll ship this in the next release 😄
This change adds a new boolean property to core: check_sorted
By default,
check_sorted = True
, which is the behavior currently whenis_sorted = True
.However, there are API's that are sorted, but not by
replication_key
.This change allows for an API that is truly ordered, but where the
replication_key
is not an incremental one.Closes #729