-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Make PyJWT
and cryptography
dependencies optional
#2525
refactor!: Make PyJWT
and cryptography
dependencies optional
#2525
Conversation
2843bab
to
6d703e2
Compare
PyJWT
and cryptography
dependencies optionalPyJWT
and cryptography
dependencies optional
CodSpeed Performance ReportMerging #2525 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2525 +/- ##
==========================================
+ Coverage 89.17% 89.23% +0.05%
==========================================
Files 54 54
Lines 4784 4782 -2
Branches 936 935 -1
==========================================
+ Hits 4266 4267 +1
+ Misses 361 359 -2
+ Partials 157 156 -1 ☔ View full report in Codecov by Sentry. |
6d703e2
to
b5e52ca
Compare
361600a
to
3272f6e
Compare
This is currently a transitive dependency that you're getting via `singer-sdk`. This will become an optional dependency with meltano/sdk#2525. This package is on an older version (0.4.1), but it's still a good idea to not import any transitive dependencies and future-proof your package. Let me know if you have any questions :)
Given how uncommon jwt-based authentication seems to be in downstream packages, I feel confident merging this and calling it out in the release notes for the next version. |
A quick gathering of some data points from MeltanoLabs:
jwt
:cryptography
:Matatika has 0 repos
Automattic has 0 repos
AutoIDM has 0 repos
Hotglue on GitHub has 1 package that imports the transitive
jwt
dependency:PyJWT
hotgluexyz/tap-stella-connect#11Hotglue on GitLab is a harder nut to crack 😅
It's possible to get more data by going through the Hub, and downloading the source code of extractors and loaders.
📚 Documentation preview 📚: https://meltano-sdk--2525.org.readthedocs.build/en/2525/