Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Make PyJWT and cryptography dependencies optional #2525

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 9, 2024

It's possible to get more data by going through the Hub, and downloading the source code of extractors and loaders.


📚 Documentation preview 📚: https://meltano-sdk--2525.org.readthedocs.build/en/2525/

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/break/crypto-deps-optional branch from 2843bab to 6d703e2 Compare July 9, 2024 19:57
@edgarrmondragon edgarrmondragon changed the title chore!: Make PyJWT and cryptography dependencies optional refactor!: Make PyJWT and cryptography dependencies optional Jul 9, 2024
Copy link

codspeed-hq bot commented Jul 9, 2024

CodSpeed Performance Report

Merging #2525 will not alter performance

Comparing edgarrmondragon/break/crypto-deps-optional (3272f6e) with main (5500e45)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (5500e45) to head (3272f6e).
Report is 142 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2525      +/-   ##
==========================================
+ Coverage   89.17%   89.23%   +0.05%     
==========================================
  Files          54       54              
  Lines        4784     4782       -2     
  Branches      936      935       -1     
==========================================
+ Hits         4266     4267       +1     
+ Misses        361      359       -2     
+ Partials      157      156       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 9, 2024 22:39
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner July 9, 2024 22:39
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/break/crypto-deps-optional branch from 6d703e2 to b5e52ca Compare July 9, 2024 23:58
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/break/crypto-deps-optional branch from 361600a to 3272f6e Compare July 10, 2024 23:52
edgarrmondragon added a commit to edgarrmondragon/tap-stella-connect that referenced this pull request Jul 11, 2024
This is currently a transitive dependency that you're getting via `singer-sdk`. This will become an optional dependency with meltano/sdk#2525.

This package is on an older version (0.4.1), but it's still a good idea to not import any transitive dependencies and future-proof your package.

Let me know if you have any questions :)
@edgarrmondragon
Copy link
Collaborator Author

Given how uncommon jwt-based authentication seems to be in downstream packages, I feel confident merging this and calling it out in the release notes for the next version.

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 9c755bf Jul 11, 2024
34 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/break/crypto-deps-optional branch July 11, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants