Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump duckdb from 0.9.2 to 0.10.0 #2237

Merged
merged 1 commit into from
Feb 13, 2024
Merged

chore(deps-dev): bump duckdb from 0.9.2 to 0.10.0 #2237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,6 @@
]


def _clean_py312_deps(session: Session, dependencies: list[str]) -> None:
"""Clean dependencies for Python 3.12."""
if session.python == "3.12":
dependencies.remove("duckdb")
dependencies.remove("duckdb-engine")


@session(python=main_python_version)
def mypy(session: Session) -> None:
"""Check types with mypy."""
Expand All @@ -87,7 +80,6 @@ def mypy(session: Session) -> None:
@session(python=python_versions)
def tests(session: Session) -> None:
"""Execute pytest tests and compute coverage."""
_clean_py312_deps(session, test_dependencies)
session.install(".[faker,parquet,s3]")
session.install(*test_dependencies)

Expand Down Expand Up @@ -121,7 +113,6 @@ def tests(session: Session) -> None:
@session(python=main_python_version)
def benches(session: Session) -> None:
"""Run benchmarks."""
_clean_py312_deps(session, test_dependencies)
session.install(".[s3]")
session.install(*test_dependencies)
sqlalchemy_version = os.environ.get("SQLALCHEMY_VERSION")
Expand All @@ -144,7 +135,6 @@ def update_snapshots(session: Session) -> None:
"""Update pytest snapshots."""
args = session.posargs or ["-m", "snapshot"]

_clean_py312_deps(session, test_dependencies)
session.install(".[faker]")
session.install(*test_dependencies)
session.run("pytest", "--snapshot-update", *args)
Expand Down
90 changes: 49 additions & 41 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 1 addition & 8 deletions tests/core/test_connector_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
from __future__ import annotations

import sys
import typing as t
from decimal import Decimal
from unittest import mock

import pytest
import sqlalchemy as sa
from sqlalchemy.dialects import registry, sqlite
from sqlalchemy.exc import NoSuchModuleError

from singer_sdk.connectors import SQLConnector
from singer_sdk.exceptions import ConfigValidationError
Expand Down Expand Up @@ -310,11 +308,6 @@ def get_column_alter_ddl(
)


@pytest.mark.xfail(
reason="DuckDB does not build on Python 3.12 yet",
condition=sys.version_info >= (3, 12),
raises=NoSuchModuleError,
)
class TestDuckDBConnector:
@pytest.fixture
def connector(self):
Expand All @@ -324,7 +317,7 @@ def test_create_schema(self, connector: DuckDBConnector):
engine = connector._engine
connector.create_schema("test_schema")
inspector = sa.inspect(engine)
assert "memory.test_schema" in inspector.get_schema_names()
assert "test_schema" in inspector.get_schema_names()

def test_column_rename(self, connector: DuckDBConnector):
engine = connector._engine
Expand Down