fix(targets): Quote column names in INSERT statement

[mattwill09]

This is an update to fix how the insert into statements are being generated. If you have a source column that uses a reserved word then invalid SQL was being generated.

Previous:

INSERT INTO analytics.foo
(id, in)
VALUES (:id, :in)

Updated:

INSERT INTO analytics.foo
("id", "in")
VALUES (:id, :in)

---

📚 Documentation preview 📚: https://meltano-sdk--2198.org.readthedocs.build/en/2198/

[edgarrmondragon]

We could try using https://docs.sqlalchemy.org/en/20/core/sqlelement.html#sqlalchemy.sql.expression.quoted_name

[mattwill09]

I'm not typically a python developer, but that change looks to be easy enough. I'll make sure to get those tests fixed up too.

[codspeed-hq]

CodSpeed Performance Report

Merging #2198 will not alter performance

_{Comparing mattwill09:main (342247a) with main (af3b678)}

Summary

✅ 6 untouched benchmarks

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af3b678) 88.43% compared to head (342247a) 88.44%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2198   +/-   ##
=======================================
  Coverage   88.43%   88.44%           
=======================================
  Files          54       54           
  Lines        4714     4715    +1     
  Branches      961      961           
=======================================
+ Hits         4169     4170    +1     
  Misses        384      384           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[edgarrmondragon]

Thanks @mattwill09!

You may want to update the test in

sdk/tests/samples/test_target_sqlite.py

Lines 490 to 495 in af3b678

	dedent(
	"""\
	INSERT INTO test_stream
	(id, name)
	VALUES (:id, :name)""",
	),

.

[edgarrmondragon]

Suggested change

	({", ".join(quoted_name(name, True) for name in property_names)})
	({", ".join(quoted_name(name, True) for name in property_names)}) # noqa: FBT003

[edgarrmondragon]

Superseded by #2200. Thanks @mattwill09!

[mattwill09]

Thanks for finding a proper solution for this. Much appreciated!