-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(targets)!: Default handling of ACTIVATE_VERSION
messages to soft deletes and add new SQLConnector.delete_old_versions
method
#2105
Merged
edgarrmondragon
merged 9 commits into
main
from
2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
Jan 10, 2024
Merged
fix(targets)!: Default handling of ACTIVATE_VERSION
messages to soft deletes and add new SQLConnector.delete_old_versions
method
#2105
edgarrmondragon
merged 9 commits into
main
from
2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
CodSpeed Performance ReportMerging #2105 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2105 +/- ##
==========================================
+ Coverage 87.84% 87.89% +0.05%
==========================================
Files 60 60
Lines 4953 4958 +5
Branches 1007 1008 +1
==========================================
+ Hits 4351 4358 +7
Misses 424 424
+ Partials 178 176 -2 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
changed the title
fix(targets): Do not handle
fix(targets): Default handling of Dec 15, 2023
ACTIVATE_VERSION
by doing hard deletes by defaultACTIVATE_VERSION
messages to soft deletes
edgarrmondragon
force-pushed
the
2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
branch
7 times, most recently
from
December 19, 2023 00:49
1e79f7a
to
5c4483a
Compare
edgarrmondragon
changed the title
fix(targets): Default handling of
fix(targets): Default handling of Dec 19, 2023
ACTIVATE_VERSION
messages to soft deletesACTIVATE_VERSION
messages to soft deletes and add new SQLConnector.delete_old_versions
method
edgarrmondragon
force-pushed
the
2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
branch
4 times, most recently
from
December 19, 2023 15:16
21ce0e9
to
580dde6
Compare
edgarrmondragon
force-pushed
the
2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
branch
2 times, most recently
from
December 20, 2023 22:16
a05c8af
to
f4539f5
Compare
edgarrmondragon
force-pushed
the
2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
branch
from
December 20, 2023 22:26
f4539f5
to
27caeb2
Compare
edgarrmondragon
changed the title
fix(targets): Default handling of
fix(targets)!: Default handling of Dec 20, 2023
ACTIVATE_VERSION
messages to soft deletes and add new SQLConnector.delete_old_versions
methodACTIVATE_VERSION
messages to soft deletes and add new SQLConnector.delete_old_versions
method
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
…ted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
edgarrmondragon
deleted the
2103-bug-activate_version-deletes-rows-inserted-in-earlier-batches-and-deletes-despite-hard_delete-not-being-set
branch
January 10, 2024 19:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
📚 Documentation preview 📚: https://meltano-sdk--2105.org.readthedocs.build/en/2105/