-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(taps): add ability to do list comprehensions in stream map expressions #2003
feat(taps): add ability to do list comprehensions in stream map expressions #2003
Conversation
Hey @haleemur, Thanks for contributing! Ping me when this is ready for review 🙂 |
Thanks for the contribution @haleemur ! @edgarrmondragon can you open a separate issue for adding this as an example to https://sdk.meltano.com/en/latest/stream_maps.html ? |
4437e4e
to
e662dd9
Compare
0495ef0
to
22ea165
Compare
I'll take a look at why mypy is complaining on 3.8, but otherwise, I think the PR is ready. When looking at the benchmark run in the workflows a significant improvement is noted (likely due to parsing only once)
Locally run benchmarks reveal a similar story.
|
Codecov Report
@@ Coverage Diff @@
## main #2003 +/- ##
==========================================
- Coverage 87.42% 86.83% -0.59%
==========================================
Files 59 58 -1
Lines 5136 4884 -252
Branches 830 777 -53
==========================================
- Hits 4490 4241 -249
- Misses 451 456 +5
+ Partials 195 187 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing. Thanks @haleemur!
Closes #2002
simpleeval
as a dependency & remove locally vendoredsimpleeval
(since simpleeval itself moved to poetry and is no longer dependent on deprecated packages https://gitlab.com/meltano/sdk/-/issues/213)ast
to parse expressions used for filtering and property mapping in stream_maps.simpleeval.EvalWithCompoundTypes
instead ofsimpleEval.SimpleEval
bool
as a new transformed type for mapped properties📚 Documentation preview 📚: https://meltano-sdk--2003.org.readthedocs.build/en/2003/