Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taps): Avoid setting up mapper in discovery mode #1835

Merged
merged 4 commits into from
Jul 13, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 12, 2023

Closes #1821


📚 Documentation preview 📚: https://meltano-sdk--1835.org.readthedocs.build/en/1835/

@edgarrmondragon edgarrmondragon requested a review from kgpayne as a code owner July 12, 2023 19:16
@edgarrmondragon edgarrmondragon linked an issue Jul 12, 2023 that may be closed by this pull request
1 task
@edgarrmondragon edgarrmondragon changed the title fix(taps): Avoid setting up mapper during discovery mode fix(taps): Avoid setting up mapper in discovery mode Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1835 (75372fe) into main (d372080) will increase coverage by 0.04%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main    #1835      +/-   ##
==========================================
+ Coverage   86.48%   86.53%   +0.04%     
==========================================
  Files          59       59              
  Lines        4974     4990      +16     
  Branches      808      811       +3     
==========================================
+ Hits         4302     4318      +16     
+ Misses        477      476       -1     
- Partials      195      196       +1     
Impacted Files Coverage Δ
singer_sdk/target_base.py 92.09% <66.66%> (-0.47%) ⬇️
singer_sdk/tap_base.py 80.80% <83.33%> (-0.28%) ⬇️
singer_sdk/plugin_base.py 86.22% <100.00%> (+2.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@pnadolny13 pnadolny13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarrmondragon I'm not sure I understand the bug completely but it sounds like you were able to replicate the error and I see the main change is that you're not setting up the mapper when doing discovery. Looks good to me!

@edgarrmondragon edgarrmondragon merged commit 2634329 into main Jul 13, 2023
@edgarrmondragon edgarrmondragon deleted the 1821-defer-setting-mapper-discovery branch July 13, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__filter__ of stream map breaks tap-postgres
2 participants