Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update testing.md #1818

Merged
merged 3 commits into from
Jul 10, 2023
Merged

docs: Update testing.md #1818

merged 3 commits into from
Jul 10, 2023

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Jul 7, 2023 •
edited by github-actions bot
Loading

I was getting ScopeMismatch: You tried to access the function scoped fixture runner with a class scoped request object in target snowflake after I upgraded to 0.29.0. Removing the class scoped fixture allowed it to pass https://github.com/MeltanoLabs/target-snowflake/compare/bump_sdk_0.29.0.

Is this correct? It seems like the scope changed in #1752 but we might have missed a docs update.

📚 Documentation preview 📚: https://meltano-sdk--1818.org.readthedocs.build/en/1818/

@pnadolny13 pnadolny13 requested review from a team as code owners July 7, 2023 17:44
@edgarrmondragon edgarrmondragon self-requested a review July 7, 2023 21:51
edgarrmondragon
edgarrmondragon requested changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed reviewing this before the related SF PR. I think using @pytest.fixture(scope="function") or @pytest.fixture() might work.

@pnadolny13
Copy link
Contributor Author

@edgarrmondragon youre right I ended up using @pytest.fixture(). I'll update this to use that.

https://github.com/MeltanoLabs/target-snowflake/blob/34b7849c82e3720d8c3a181365cd029290cb7ed8/tests/test_target_snowflake.py#L38

@edgarrmondragon edgarrmondragon merged commit c5434c1 into main Jul 10, 2023
@edgarrmondragon edgarrmondragon deleted the target_test_docs branch July 10, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnadolny13 @edgarrmondragon