chore: Update CI template for tap cookiecutter #1476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentS
requested review from
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
laurentS
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1476 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 57 57
Lines 4760 4760
Branches 809 809
=======================================
Hits 4068 4068
Misses 501 501
Partials 191 191 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
WillDaSilva
reviewed
Mar 3, 2023
There was a problem hiding this comment.
Thanks @laurentS! I've got one suggestion, but aside from that this looks good to me.
...flows/{% if cookiecutter.include_cicd_sample_template == 'GitHub' %}ci_workflow.yml{%endif%}
Outdated
Show resolved
Hide resolved
| with: | ||
| python-version: {{ '${{ matrix.python-version }}' }} | ||
| - name: Install Poetry | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install poetry==1.2.* | ||
| pip install poetry==1.3.* |
There was a problem hiding this comment.
We should probably use a constraints file do this can be kept up to date with dependabot. But that's for a future PR.
…flows/{% if cookiecutter.include_cicd_sample_template == 'GitHub' %}ci_workflow.yml{%endif%}
Co-authored-by: Will Da Silva <[email protected]>
|
Just saw your other PR @WillDaSilva closing this as not needed anymore, but please let me know if I missed anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just built a fresh tap using the cookiecutter template (which was super cool by the way!), and had to update some parts of the workflow template as below to fix github complaints (and use latest versions of python and poetry).
📚 Documentation preview 📚: https://meltano-sdk--1476.org.readthedocs.build/en/1476/