Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TapDiscoveryTest remove catalog if one is passed #1364

Merged
merged 4 commits into from
Feb 1, 2023
+3 −2
Merged

fix: TapDiscoveryTest remove catalog if one is passed #1364

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44b4b02
TapDiscoveryTest remove catalog if one is passed
Jan 30, 2023
18ef553
Merge branch 'main' into kgpayne/fix-test-tap-discovery
Jan 30, 2023
7c72169
Merge branch 'main' into kgpayne/fix-test-tap-discovery
Jan 31, 2023
f61e608
Merge branch 'main' into kgpayne/fix-test-tap-discovery
Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions singer_sdk/testing/tap_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ def test(self) -> None:
tap1 = self.tap
tap1.run_discovery()
catalog = tap1.catalog_dict
# Reset and re-initialize with an input catalog
# Reset and re-initialize with discovered catalog
kwargs = {k: v for k, v in self.runner.default_kwargs.items() if k != "catalog"}
tap2: Tap = cast(Type[Tap], self.runner.singer_class)(
config=self.runner.config, catalog=catalog, **self.runner.default_kwargs
config=self.runner.config, catalog=catalog, **kwargs
)
assert tap2

Expand Down