Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Read plugin version from distribution, with fallback to package #1254
feat: Read plugin version from distribution, with fallback to package #1254
Changes from 8 commits
1a28cbb
a0542fa
c789633
4a35cf3
699d94b
51040fc
ca93070
82c4cdf
14ad687
abaf4aa
67ce949
17a64b9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the package name can't be retrieved in Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means the lookup via distribution will not work, yes. The fallback to
metadata.version(cls.name)
was the primary mechanism before this change (it relies on the library name being the same as the class name), though I don't know how well it worked for Windows in the first place 🤔Given the hurdles we have to jump through to try and infer the plugin version via distribution or library metadata, I still think we are better off adding
__version__ = "<version>"
in__init__.py
and importing that for--about
.poetry-dynamic-versioning
supports substitution from a0.0.0
placeholder in any file (including__init__.py
by default), and this approach is standard in other python packages 🤷♂️ This PR specifically addresses this ask from @aaronsteers 👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgpayne Yeah, I'd say it's probably not worth spending time trying to solve a problem that's only present when migrating existing taps and targets that are published to PyPI. Wdyt?