-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle merging of SQL types when character column lengths are less than the max #1172
fix: Handle merging of SQL types when character column lengths are less than the max #1172
Conversation
@edgarrmondragon @aaronsteers I merged the latest main containing PR 1168 into this branch ran my tests locally. The code is working as planned and I am past the error:
|
I just ran into an issue with this. If the
|
I put in place a fix for the |
Co-authored-by: Edgar R. M. <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
+ Coverage 85.71% 85.73% +0.01%
==========================================
Files 57 57
Lines 4691 4689 -2
Branches 802 801 -1
==========================================
- Hits 4021 4020 -1
Misses 481 481
+ Partials 189 188 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…-fix-merge-sql-type-to-handle-lengths-not-eq-max
merge_sql_type
to handle instances when all passed character column lengths are less than max
Thanks @BuzzCutNorman and sorry for the delay in reviews! |
@edgarrmondragon, no worries. Thanks for all your great guidance. |
This is an attempt to fix
merge_sql_type
to handle instances when all passed character column lengths are less than max. SDK 0.13.1 needs PR #1168 present to reach this fix.fixes #1170
📚 Documentation preview 📚: https://meltano-sdk--1172.org.readthedocs.build/en/1172/