Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow authenticating more generic requests #842

Merged
merged 7 commits into from
Aug 24, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 20, 2022

Closes #170

@edgarrmondragon edgarrmondragon self-assigned this Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #842 (79c70e3) into main (797226a) will increase coverage by 0.02%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   80.37%   80.40%   +0.02%     
==========================================
  Files          34       34              
  Lines        3425     3429       +4     
  Branches      681      681              
==========================================
+ Hits         2753     2757       +4     
  Misses        499      499              
  Partials      173      173              
Impacted Files Coverage Δ
singer_sdk/streams/rest.py 82.60% <85.71%> (+0.10%) ⬆️
singer_sdk/authenticators.py 64.36% <100.00%> (+0.62%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 24, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Authenticator to mutate outgoing request
2 participants