We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taps (catalog, state, stream maps, etc.)
Some of these are nice, and would at least remove from duplication on our side:
requests.auth.HTTPBasicAuth(username, password) Attaches HTTP Basic Authentication to the given Request object.
requests.auth.HTTPProxyAuth(username, password) Attaches HTTP Proxy Authentication to a given Request object.
requests.auth.HTTPDigestAuth(username, password) Attaches HTTP Digest Authentication to the given Request object.
https://requests.readthedocs.io/en/latest/api/#authentication
Custom authenticators are also interesting, and developers would be able to leverage existing auth packages in the wild:
https://requests.readthedocs.io/en/latest/user/advanced/#custom-authentication
The implementation seems easy enough as we already did most of the work in #842. We'd only need to add a __call__ method to the base auth class:
__call__
class APIAuthenticatorBase: def __call__(self, request): return self.authenticate_request(request)
and also set the auth attribute of the session:
auth
class RESTStream: def build_prepared_request( self, *args: Any, **kwargs: Any, ) -> requests.PreparedRequest: ... self.requests_session.auth = self.authenticator return self.requests_session.prepare_request(request)
The text was updated successfully, but these errors were encountered:
requests.auth
singer_sdk.authenticators.BasicAuthenticator
requests.auth.HTTPBasicAuth
edgarrmondragon
Successfully merging a pull request may close this issue.
Feature scope
Taps (catalog, state, stream maps, etc.)
Description
Some of these are nice, and would at least remove from duplication on our side:
requests.auth.HTTPBasicAuth(username, password)
Attaches HTTP Basic Authentication to the given Request object.
requests.auth.HTTPProxyAuth(username, password)
Attaches HTTP Proxy Authentication to a given Request object.
requests.auth.HTTPDigestAuth(username, password)
Attaches HTTP Digest Authentication to the given Request object.
https://requests.readthedocs.io/en/latest/api/#authentication
Custom authenticators are also interesting, and developers would be able to leverage existing auth packages in the wild:
https://requests.readthedocs.io/en/latest/user/advanced/#custom-authentication
The implementation seems easy enough as we already did most of the work in #842. We'd only need to add a
__call__
method to the base auth class:and also set the
auth
attribute of the session:The text was updated successfully, but these errors were encountered: