Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document that get_starting_timestamp requires setting a non-null replication_key #2557

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 20, 2024

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 20, 2024 00:21
Copy link

codspeed-hq bot commented Jul 20, 2024

CodSpeed Performance Report

Merging #2557 will not alter performance

Comparing 320-docs-document-that-get_starting_timestamp-requires-setting-a-non-null-replication_key (66c8046) with main (4cafb6f)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (4cafb6f) to head (66c8046).
Report is 133 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2557   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files          58       58           
  Lines        4795     4795           
  Branches      937      937           
=======================================
  Hits         4290     4290           
  Misses        352      352           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon merged commit 9c97d4a into main Jul 20, 2024
35 checks passed
@edgarrmondragon edgarrmondragon deleted the 320-docs-document-that-get_starting_timestamp-requires-setting-a-non-null-replication_key branch July 20, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Document that get_starting_timestamp requires setting a non-null replication_key
1 participant