Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document that get_starting_timestamp requires setting a non-null replication_key #320

Closed
MeltyBot opened this issue Jan 31, 2022 · 6 comments · Fixed by #2557
Closed
Labels

Comments

@MeltyBot
Copy link
Contributor

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/322

Originally created by @edgarrmondragon on 2022-01-31 19:53:18


From slack thread: https://meltano.slack.com/archives/C01TCRBBJD7/p1643646009947879

Stream.get_starting_timestamp(context) returns None if Stream.replication_key is not set for the stream. Documentation for get_starting_timestamp(context) should indicate that requirement.

@MeltyBot
Copy link
Contributor Author

@labelsync-manager labelsync-manager bot added the kind/Bug Something isn't working label Jun 23, 2022
@tayloramurphy
Copy link
Collaborator

@edgarrmondragon is this still relevant?

@tayloramurphy tayloramurphy changed the title Document that get_starting_timestamp requires setting a non-null replication_key docs: Document that get_starting_timestamp requires setting a non-null replication_key Dec 19, 2022
@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Feb 15, 2023

@edgarrmondragon is this still relevant?

@tayloramurphy yeah, still relevant. We do have https://sdk.meltano.com/en/latest/incremental_replication.html now, but it wouldn't hurt to be explicit.

@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 18, 2023
@edgarrmondragon
Copy link
Collaborator

Still relevant

@stale stale bot removed the stale label Jul 20, 2023
Copy link

stale bot commented Jul 19, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants