-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configurable object/column name formatting options for targets #2490
Comments
Yes, good part is there's already a function for this Line 134 in 6334091
I overrode this as I wanted "direct mapping" in your list to be the default not snake_case see https://github.com/MeltanoLabs/target-postgres/blob/1e59be2750961876d52b8e69cf05c5eb06cb13b4/target_postgres/sinks.py#L280-L282 There was a longer discussion about this here #1205 I think the idea of a config option to choose between them is a good one! |
@edgarrmondragon had proposed using the humps library for this. |
* [`inflection` last version](https://pypi.org/project/inflection/) is from 2020/08/20 * [`pyhumps` last version](https://pypi.org/project/pyhumps/) is from 2022/10/21 Related: * #2490 (comment)
* [`inflection` last version](https://pypi.org/project/inflection/) is from 2020/08/20 * [`pyhumps` last version](https://pypi.org/project/pyhumps/) is from 2022/10/21 Related: * #2490 (comment)
* [`inflection` last version](https://pypi.org/project/inflection/) is from 2020/08/20 * [`pyhumps` last version](https://pypi.org/project/pyhumps/) is from 2022/10/21 Related: * #2490 (comment)
Related request #2545 (comment) |
* [`inflection` last version](https://pypi.org/project/inflection/) is from 2020/08/20 * [`pyhumps` last version](https://pypi.org/project/pyhumps/) is from 2022/10/21 Related: * #2490 (comment)
I'm currently looking for same use case - i'd like to convert all column names to lower case (source is tap-mssql, and loader is target-postgres). In my case tables have around 100 columns, so making it manually per column doesn't seem inviting :) |
I think what could happen is that with this new configuration set, PluginMapper can take it into account in |
Feature scope
Targets (data type handling, batching, SQL object generation, tests, etc.)
Description
It would be helpful if there is a way to configure the column and object names that get mapped from the extractor.
Nice to have: some targets also have the ability to specify column names that are outside of the normal specs. For example, SQL Server can have column names with any character when qualified with square brackets, PostgreSQL/Snowflake can do the same with double quotes, etc. This would be an additional option to use the appropriate identifiers across the board when referencing objects/fields at the target. It would not be desirable to always force this option, as for example, Snowflake becomes case-sensitive when double quotes are provided.
The text was updated successfully, but these errors were encountered: