Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taps): Unmapped sub-fields in object-type fields are now no longer dropped when the field declares additionalProperties #2301

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Mar 8, 2024

Closes #2300


📚 Documentation preview 📚: https://meltano-sdk--2301.org.readthedocs.build/en/2301/

@edgarrmondragon edgarrmondragon linked an issue Mar 8, 2024 that may be closed by this pull request
1 task
Copy link

codspeed-hq bot commented Mar 8, 2024

CodSpeed Performance Report

Merging #2301 will not alter performance

Comparing 2300-bug-object-properties-are-dropped-even-when-additionalproperties-is-used (12b8282) with main (a65c561)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (a65c561) to head (12b8282).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2301      +/-   ##
==========================================
+ Coverage   88.74%   88.76%   +0.01%     
==========================================
  Files          54       54              
  Lines        4772     4779       +7     
  Branches      929      930       +1     
==========================================
+ Hits         4235     4242       +7     
  Misses        374      374              
  Partials      163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review March 8, 2024 21:06
@edgarrmondragon edgarrmondragon requested a review from kgpayne as a code owner March 8, 2024 21:06
@edgarrmondragon edgarrmondragon force-pushed the 2300-bug-object-properties-are-dropped-even-when-additionalproperties-is-used branch from 3282de2 to ba222ac Compare March 12, 2024 17:19
@edgarrmondragon edgarrmondragon merged commit 0eb478c into main Apr 4, 2024
32 checks passed
@edgarrmondragon edgarrmondragon deleted the 2300-bug-object-properties-are-dropped-even-when-additionalproperties-is-used branch April 4, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Object properties are dropped even when additionalProperties is used
1 participant