Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Object properties are dropped even when additionalProperties is used #2300

Closed
1 task
edgarrmondragon opened this issue Mar 8, 2024 · 0 comments · Fixed by #2301
Closed
1 task

bug: Object properties are dropped even when additionalProperties is used #2300

edgarrmondragon opened this issue Mar 8, 2024 · 0 comments · Fixed by #2301
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

Singer SDK Version

0.36.0

Is this a regression?

  • Yes

Python Version

3.6 (EOL)

Bug scope

Taps (catalog, state, etc.)

Operating System

Any

Description

Our type-conformance implementation drops fields from records when they're missing from the schema. That is fine in all cases, except when the schema explicitly states that an object can have dynamic or additional custom fields by setting additionalProperties to either true or a valid JSON schema.

Code

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Milestone
No milestone
1 participant
@edgarrmondragon