Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support parsing tap metadata sql-datatype in SQL targets #1903

Open
edgarrmondragon opened this issue Aug 8, 2023 · 1 comment · May be fixed by #1872
Open

feat: Support parsing tap metadata sql-datatype in SQL targets #1903

edgarrmondragon opened this issue Aug 8, 2023 · 1 comment · May be fixed by #1872
Labels
kind/Feature New feature or request SQL Support for SQL taps and targets valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Aug 8, 2023

Feature scope

Targets (data type handling, batching, SQL object generation, tests, etc.)

Description

Follow-on from #1323

@edgarrmondragon
Copy link
Collaborator Author

Copying here my comment from #1872 (comment):

One thing that unfortunately isn't very clear to me is how are targets supposed to consume this information since a target isn't aware of the tap's metadata. It might be better if this metadata lived in the schema, at least that way it would be emitted with SCHEMA messages and could be used by the target.

The official Singer docs only explain the field as Represents the datatype of a database column, and pipelinewise's taps implement but the target don't seem to use it in any way:

https://github.com/search?q=org%3Atransferwise+sql-datatype+language%3APython&type=code&l=Python

Otherwise, who is the consumer of this metadata?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Feature New feature or request SQL Support for SQL taps and targets valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant