-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Add sql-datatype
to the SDK discovery and catalog.
#1323
Comments
sql-datatype
to the SDK discovery and catalog sql-datatype
to the SDK discovery and catalog.
This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the |
Related: #1903 |
Copying here my comment from #1872 (comment): One thing that unfortunately isn't very clear to me is how are targets supposed to consume this information since a target isn't aware of the tap's metadata. It might be better if this metadata lived in the schema, at least that way it would be emitted with The official Singer docs only explain the field as Otherwise, who is the consumer of this metadata? |
I am guessing the consumer might be the Stich platform. During this conversation I had in the Meltano Slack: https://discuss.meltano.com/t/16288098/i-was-wondering-if-i-someone-could-point-me-in-the-proper-di We came to the same conclusion that this would need to be a part of the knowing the database type (posgresql, sql server, oracle) and sql data type ( integer(), varchar(10) ) would be easier and maybe more accurate than the JSON Schema fingerprint method. I find myself looking back on this and almost thinking this feature request should be closed. Please let me know wdyt? |
Feature scope
Taps (catalog, state, stream maps, etc.)
Description
It would be very helpful if SDK based taps during the discovery process of a database grabbed column data types and placed them into the catalog metadata area for the column in the field of
sql-datatype
. Thesql-datatype
field is a reserved keyword mentioned in the singer discovery documentation.https://github.com/singer-io/getting-started/blob/master/docs/DISCOVERY_MODE.md#metadata
sql-datatype
The text was updated successfully, but these errors were encountered: