Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure all expected tap parameters are passed to SQLTap initializer #1842

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 14, 2023

Fixes the broken initialization of SQL taps following #1835.

The subclass initializer doesn't introduce any new arguments, so this PR changes it to use *args and **kwargs so we don't miss any changes to the parent class' initializer.

cc @BuzzCutNorman


📚 Documentation preview 📚: https://meltano-sdk--1842.org.readthedocs.build/en/1842/

@edgarrmondragon edgarrmondragon requested a review from kgpayne as a code owner July 14, 2023 15:35
@edgarrmondragon edgarrmondragon changed the title fix: Ensure all tap parameters are passed to SQLTap initializer fix: Ensure all expected tap parameters are passed to SQLTap initializer Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1842 (e6e020d) into main (e655386) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1842      +/-   ##
==========================================
+ Coverage   86.56%   86.68%   +0.12%     
==========================================
  Files          59       59              
  Lines        5000     5000              
  Branches      811      811              
==========================================
+ Hits         4328     4334       +6     
+ Misses        476      470       -6     
  Partials      196      196              
Impacted Files Coverage Δ
singer_sdk/tap_base.py 83.40% <100.00%> (+2.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator Author

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tap.__init__ and SQLTap.__init__ have the same signature so this feels like a safe change. Merging.

@edgarrmondragon edgarrmondragon merged commit e36da21 into main Jul 19, 2023
@edgarrmondragon edgarrmondragon deleted the fix/ensure-init-args-sqltap branch July 19, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant