Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(targets): Check schema has arrived before any record #1770

Merged
merged 4 commits into from
Jul 4, 2023

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Jun 16, 2023

Closes #1146

@kgpayne kgpayne requested a review from edgarrmondragon as a code owner June 16, 2023 14:38
@kgpayne
Copy link
Contributor Author

kgpayne commented Jun 16, 2023

cc @visch

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1770 (a4b8221) into main (5f59f38) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head a4b8221 differs from pull request most recent head c51b0cd. Consider uploading reports for the commit c51b0cd to get more accurate results

@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
- Coverage   86.29%   86.18%   -0.11%     
==========================================
  Files          59       59              
  Lines        4960     4945      -15     
  Branches      811      809       -2     
==========================================
- Hits         4280     4262      -18     
- Misses        481      483       +2     
- Partials      199      200       +1     
Impacted Files Coverage Δ
singer_sdk/target_base.py 92.52% <100.00%> (+1.40%) ⬆️
singer_sdk/testing/target_tests.py 94.00% <100.00%> (+0.12%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@visch
Copy link
Contributor

visch commented Jun 21, 2023

cc @visch

Looks good I'll get an issue in to migrate target-postgres once this is released

@kgpayne kgpayne enabled auto-merge (squash) June 27, 2023 14:11
@edgarrmondragon edgarrmondragon changed the title fix: check schema has arrived before record fix(targets): Check schema has arrived before any record Jul 4, 2023
@kgpayne kgpayne merged commit efd9fb6 into main Jul 4, 2023
@kgpayne kgpayne deleted the kgpayne/record-before-stream-error branch July 4, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: SQLTarget Record before Schema should fail nicely
3 participants