Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: SQLTarget Record before Schema should fail nicely #1146

Closed
visch opened this issue Nov 5, 2022 · 1 comment · Fixed by #1770
Closed

[Feature]: SQLTarget Record before Schema should fail nicely #1146

visch opened this issue Nov 5, 2022 · 1 comment · Fixed by #1770
Assignees
@kgpayne
Labels
kind/Feature New feature or request valuestream/SDK
Milestone
SQL Target Out-of...

Comments

@visch
Copy link
Contributor

visch commented Nov 5, 2022

Feature scope

Targets (data type handling, batching, SQL object generation, etc.)

Description

Should go on SQL Target milestone

https://github.com/MeltanoLabs/target-postgres/blob/main/target_postgres/tests/test_standard_target.py#L64 is the record_before_schema test

We should fail nicely, this test was taken from https://github.com/MeltanoLabs/target-sqlite/blob/master/tests/test_target_sqlite.py#L23-L32

We should probably do the validation in the SDK
@visch visch added kind/Feature New feature or request valuestream/SDK labels Nov 5, 2022
@visch
Copy link
Contributor Author

visch commented Dec 20, 2022

Here's an example implementation MeltanoLabs/target-postgres#57

@visch visch mentioned this issue Jun 7, 2023
Closed
1 task
@kgpayne kgpayne self-assigned this Jun 9, 2023
@kgpayne kgpayne mentioned this issue Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgpayne kgpayne

Labels
kind/Feature New feature or request valuestream/SDK
Projects
None yet
Milestone
SQL Target Out-of-Box Stability
Development

Successfully merging a pull request may close this issue.

fix(targets): Check schema has arrived before any record meltano/sdk
3 participants
@kgpayne @visch @aaronsteers