Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: RECORD before SCHEMA message throws a KeyError, rather than an informative error #1755

Closed
1 task
kgpayne opened this issue Jun 7, 2023 · 4 comments
Closed
1 task

bug: RECORD before SCHEMA message throws a KeyError, rather than an informative error #1755

kgpayne opened this issue Jun 7, 2023 · 4 comments
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@kgpayne
Copy link
Contributor

kgpayne commented Jun 7, 2023

Singer SDK Version

0.28.0

Is this a regression?

  • Yes

Python Version

3.10

Bug scope

Targets (data type handling, batching, SQL object generation, etc.)

Operating System

MacOS

Description

It would be helpful in debugging Taps if errors relating to contravention of the Singer Spec were raised in SDK-based Targets with informative error messages.

Code

No response
@kgpayne kgpayne added kind/Bug Something isn't working valuestream/SDK labels Jun 7, 2023
@kgpayne
Copy link
Contributor Author

kgpayne commented Jun 7, 2023

See test case here for details on KeyError

@kgpayne
Copy link
Contributor Author

kgpayne commented Jun 7, 2023

Similarly this Exception relating to "line missing required keys" is less helpful than understanding a SCHEMA was sent without a properties key. Test case here.

@visch
Copy link
Contributor

visch commented Jun 7, 2023

#1146 :)

@kgpayne
Copy link
Contributor Author

kgpayne commented Jun 9, 2023

Closed as duplicate of #1146 and #1147. Thanks @visch 👍

@kgpayne kgpayne closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgpayne @visch