fix(taps): Ensure metric tags coming from stream context can be JSON-serialized #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
requested review from
cjohnhanson and
aaronsteers
as code owners
|
cc @rabidaudio this is blocking tap-lastfm from working with the latest SDK. |
Codecov Report
@@ Coverage Diff @@
## main #1238 +/- ##
=======================================
Coverage 83.67% 83.67%
=======================================
Files 42 42
Lines 3909 3909
Branches 666 666
=======================================
Hits 3271 3271
Misses 474 474
Partials 164 164
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
force-pushed
the
fix/json-serializable-metric-tags
branch
from
1888f57 to
5c8987d
Compare
edgarrmondragon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise adding objects in a streams
contextthat can't be JSON-serialized cause the tap to fail.For example, pendulum objects in tap-lastfm.
Closes #1239