Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Tap fails when metric tags are not JSON serializable #1239

Closed
edgarrmondragon opened this issue Dec 2, 2022 · 0 comments · Fixed by #1238
Closed

[Bug]: Tap fails when metric tags are not JSON serializable #1239

edgarrmondragon opened this issue Dec 2, 2022 · 0 comments · Fixed by #1238
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

Singer SDK Version

0.14.0

Python Version

NA

Bug scope

Taps (catalog, state, stream maps, etc.)

Operating System

NA

Description

Adding objects in a streams context that can't be JSON-serialized cause the tap to fail.

For example, pendulum objects in tap-lastfm.

Code

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(taps): Ensure metric tags coming from stream context can be JSON-serialized meltano/sdk
1 participant
@edgarrmondragon