-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support requests.auth
authenticators
#1109
Conversation
115c993
to
869b0b2
Compare
e42d47d
to
b4dc4fc
Compare
Codecov Report
@@ Coverage Diff @@
## main #1109 +/- ##
==========================================
+ Coverage 85.12% 85.19% +0.06%
==========================================
Files 54 54
Lines 4694 4708 +14
Branches 798 800 +2
==========================================
+ Hits 3996 4011 +15
+ Misses 507 506 -1
Partials 191 191
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b4dc4fc
to
861c21e
Compare
@edgarrmondragon - This one went under my radar and I'm just reading through now. Can you add a usage example in one of the sample implementations, or in the Or is it proper to think of this as fully internal to the SDK and the dev-side experience is basically the same? |
8554e26
to
9657452
Compare
9657452
to
c6caacc
Compare
@aaronsteers thanks for taking a look! I've added a simple example with links to community-supported authentication classes: |
@edgarrmondragon - Super helpful!! Thank you! I was going to ask for links and then realized they are already linked 😅. LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge when ready. 🚀
Closes #1105
📚 Documentation preview 📚: https://meltano-sdk--1109.org.readthedocs.build/en/1109/