Skip to content

Commit

Permalink
Merge branch 'main' into add-column-db-quoting
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon authored Aug 1, 2024
2 parents 6d89d02 + b5ed825 commit a48a3be
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 163 deletions.
1 change: 1 addition & 0 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ In general, PR titles should follow the format `<type>: <desc>`, where type is a
- `docs`
- `feat`
- `fix`
- `packaging`
- `perf`
- `refactor`
- `revert`
Expand Down
153 changes: 1 addition & 152 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 0 additions & 9 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ joblib = ">=1.3.0"
jsonpath-ng = ">=1.5.3"
jsonschema = ">=4.16.0"
packaging = ">=23.1"
pendulum = ">=2.1.0,<4"
python-dateutil = ">=2.8.2"
python-dotenv = ">=0.20"
PyYAML = ">=6.0"
referencing = ">=0.30.0"
Expand Down Expand Up @@ -136,7 +134,6 @@ xdoctest = ">=1.1.1"
[tool.poetry.group.typing.dependencies]
mypy = ">=1.9"
types-jsonschema = ">=4.17.0.6"
types-python-dateutil = ">=2.8.19"
types-pytz = ">=2022.7.1.2"
types-requests = ">=2.28.11"
types-simplejson = ">=3.18.0"
Expand Down Expand Up @@ -239,9 +236,6 @@ types-requests = "requests"

[tool.deptry.per_rule_ignores]
DEP002 = [
# Deprecated dependencies
"pendulum",
"python-dateutil",
# Transitive constraints
"numpy",
"urllib3",
Expand Down Expand Up @@ -409,9 +403,6 @@ typing = "t"
fixture-parentheses = false
parametrize-names-type = "csv"

[tool.ruff.lint.flake8-tidy-imports.banned-api]
"pendulum".msg = "BAN002: pendulum is banned"

[tool.ruff.lint.isort]
known-first-party = ["singer_sdk", "samples", "tests"]
required-imports = ["from __future__ import annotations"]
Expand Down
4 changes: 2 additions & 2 deletions singer_sdk/streams/sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import singer_sdk.helpers._catalog as catalog
from singer_sdk._singerlib import CatalogEntry, MetadataMapping
from singer_sdk.connectors import SQLConnector
from singer_sdk.streams.core import Stream
from singer_sdk.streams.core import REPLICATION_INCREMENTAL, Stream

if t.TYPE_CHECKING:
from singer_sdk.helpers.types import Context
Expand Down Expand Up @@ -227,7 +227,7 @@ def is_sorted(self) -> bool:
Returns:
`True` if stream is sorted. Defaults to `False`.
"""
return self.replication_key is not None
return self.replication_method == REPLICATION_INCREMENTAL


__all__ = ["SQLConnector", "SQLStream"]

0 comments on commit a48a3be

Please sign in to comment.