chore: Update meltano.yml in templates (#2550)

meltano · Jul 19, 2024 · 119a5ec · 119a5ec
1 parent 9901d85
commit 119a5ec
Show file tree

Hide file tree

Showing 6 changed files with 58 additions and 20 deletions.
diff --git a/cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/meltano.yml b/cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/meltano.yml
@@ -13,18 +13,26 @@ plugins:
       streams:
       - stream_name: animals
         input_filename: https://raw.githubusercontent.com/meltano/tap-smoke-test/main/demo-data/animals-data.jsonl
+
   loaders:
   - name: target-jsonl
     variant: andyh1203
     pip_url: target-jsonl
+
   mappers:
   - name: "{{cookiecutter.mapper_id}}"
-    pip_url: -e .
     namespace: "{{cookiecutter.library_name}}"
-    # TODO: replace these with the actual settings
+    pip_url: -e .
+
+    # TODO: Declare settings and their types here:
     settings:
     - name: example_config
       kind: string
+      label: Example Config
+      description: An example configuration setting
+
+    # TODO: Declare mapping instances here:
+    # https://docs.meltano.com/guide/mappers/#example-1
     mappings:
     - name: example
       config:

diff --git a/cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/pyproject.toml b/cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/pyproject.toml
@@ -5,7 +5,7 @@ name = "{{cookiecutter.variant}}-{{cookiecutter.mapper_id}}"
 name = "{{cookiecutter.mapper_id}}"
 {%- endif %}
 version = "0.0.1"
-description = "`{{cookiecutter.mapper_id}}` is a Singer mapper {{cookiecutter.name}}, built with the Meltano Singer SDK."
+description = "Singer mapper {{cookiecutter.name}}, built with the Meltano Singer SDK."
 readme = "README.md"
 authors = ["{{ cookiecutter.admin_name }} <{{ cookiecutter.admin_email }}>"]
 keywords = [
@@ -35,7 +35,7 @@ singer-sdk = { version="~=0.38.0"{{ ', extras = ["faker"]' if cookiecutter.faker
 fs-s3fs = { version = "~=1.1.1", optional = true }
 
 [tool.poetry.group.dev.dependencies]
-pytest = ">=7.4.0"
+pytest = ">=8"
 singer-sdk = { version="~=0.38.0", extras = ["testing"] }
 
 [tool.poetry.extras]

diff --git a/cookiecutter/tap-template/{{cookiecutter.tap_id}}/meltano.yml b/cookiecutter/tap-template/{{cookiecutter.tap_id}}/meltano.yml
@@ -15,16 +15,32 @@ plugins:
     - discover
     - about
     - stream-maps
-    config:
-      start_date: '2010-01-01T00:00:00Z'
+
+    # TODO: Declare settings and their types here:
     settings:
-    # TODO: To configure using Meltano, declare settings and their types here:
     - name: username
+      label: Username
+      description: The username to use for authentication
+
     - name: password
       kind: password
+      label: Password
+      description: The password to use for authentication
       sensitive: true
+
     - name: start_date
-      value: '2010-01-01T00:00:00Z'
+      kind: date_iso8601
+      label: Start Date
+      description: Initial date to start extracting data from
+
+    # TODO: Declare required settings here:
+    settings_group_validation:
+    - [username, password]
+
+    # TODO: Declare default configuration values here:
+    config:
+      start_date: '2010-01-01T00:00:00Z'
+
   loaders:
   - name: target-jsonl
     variant: andyh1203

diff --git a/cookiecutter/tap-template/{{cookiecutter.tap_id}}/pyproject.toml b/cookiecutter/tap-template/{{cookiecutter.tap_id}}/pyproject.toml
@@ -5,7 +5,7 @@ name = "{{cookiecutter.variant}}-{{cookiecutter.tap_id}}"
 name = "{{cookiecutter.tap_id}}"
 {%- endif %}
 version = "0.0.1"
-description = "`{{cookiecutter.tap_id}}` is a Singer tap for {{cookiecutter.source_name}}, built with the Meltano Singer SDK."
+description = "Singer tap for {{cookiecutter.source_name}}, built with the Meltano Singer SDK."
 readme = "README.md"
 authors = ["{{ cookiecutter.admin_name }} <{{ cookiecutter.admin_email }}>"]
 keywords = [
@@ -37,11 +37,11 @@ singer-sdk = { version="~=0.38.0", extras = [
 ] }
 fs-s3fs = { version = "~=1.1.1", optional = true }
 {%- if cookiecutter.stream_type in ["REST", "GraphQL"] %}
-requests = "~=2.32.0"
+requests = "~=2.32.3"
 {%- endif %}
 
 [tool.poetry.group.dev.dependencies]
-pytest = ">=7.4.0"
+pytest = ">=8"
 {%- if cookiecutter.auth_method == "JWT" %}
 singer-sdk = { version="~=0.38.0", extras = ["jwt", "testing"] }
 {%- else %}

diff --git a/cookiecutter/target-template/{{cookiecutter.target_id}}/meltano.yml b/cookiecutter/target-template/{{cookiecutter.target_id}}/meltano.yml
@@ -5,7 +5,15 @@ default_environment: test
 environments:
 - name: test
 plugins:
-  extractors: []
+  extractors:
+  - name: tap-smoke-test
+    variant: meltano
+    pip_url: git+https://github.com/meltano/tap-smoke-test.git
+    config:
+      streams:
+      - stream_name: animals
+        input_filename: https://raw.githubusercontent.com/meltano/tap-smoke-test/main/demo-data/animals-data.jsonl
+
   loaders:
   - name: "{{cookiecutter.target_id}}"
     namespace: "{{cookiecutter.library_name}}"
@@ -14,13 +22,19 @@ plugins:
     - about
     - stream-maps
     - record-flattening
-    config:
-      start_date: '2010-01-01T00:00:00Z'
+
+    # TODO: Declare settings and their types here:
     settings:
-    # TODO: To configure using Meltano, declare settings and their types here:
     - name: username
+      label: Username
+      description: The username to use for authentication
+
     - name: password
       kind: password
+      label: Password
+      description: The password to use for authentication
       sensitive: true
-    - name: start_date
-      value: '2010-01-01T00:00:00Z'
+
+    # TODO: Declare required settings here:
+    settings_group_validation:
+    - [username, password]
diff --git a/cookiecutter/target-template/{{cookiecutter.target_id}}/pyproject.toml b/cookiecutter/target-template/{{cookiecutter.target_id}}/pyproject.toml
@@ -5,7 +5,7 @@ name = "{{cookiecutter.variant}}-{{cookiecutter.target_id}}"
 name = "{{cookiecutter.target_id}}"
 {%- endif %}
 version = "0.0.1"
-description = "`{{cookiecutter.target_id}}` is a Singer target for {{cookiecutter.destination_name}}, built with the Meltano Singer SDK."
+description = "Singer target for {{cookiecutter.destination_name}}, built with the Meltano Singer SDK."
 readme = "README.md"
 authors = ["{{ cookiecutter.admin_name }} <{{ cookiecutter.admin_email }}>"]
 keywords = [
@@ -33,11 +33,11 @@ python = ">=3.8"
 singer-sdk = { version="~=0.38.0"{{ ', extras = ["faker"]' if cookiecutter.faker_extra }} }
 fs-s3fs = { version = "~=1.1.1", optional = true }
 {%- if cookiecutter.serialization_method != "SQL" %}
-requests = "~=2.32.0"
+requests = "~=2.32.3"
 {%- endif %}
 
 [tool.poetry.dev-dependencies]
-pytest = ">=7.4.0"
+pytest = ">=8"
 singer-sdk = { version="~=0.38.0", extras = ["testing"] }
 
 [tool.poetry.extras]