fix: push _MAX_RECORDS_LIMIT down into SQL (#1111)

meltano · Oct 26, 2022 · 0122d47 · 0122d47
1 parent 1d1ba19
commit 0122d47
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/singer_sdk/streams/sql.py b/singer_sdk/streams/sql.py
@@ -181,6 +181,7 @@ def get_records(self, context: dict | None) -> Iterable[dict[str, Any]]:
             column_names=selected_column_names,
         )
         query = table.select()
+
         if self.replication_key:
             replication_key_col = table.columns[self.replication_key]
             query = query.order_by(replication_key_col)
@@ -193,6 +194,9 @@ def get_records(self, context: dict | None) -> Iterable[dict[str, Any]]:
                     )
                 )
 
+        if self._MAX_RECORDS_LIMIT is not None:
+            query = query.limit(self._MAX_RECORDS_LIMIT)
+
         for record in self.connector.connection.execute(query):
             yield dict(record)