Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to test Meltano add/install for changed plugins #1727

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Add workflow to test Meltano add/install for changed plugins #1727

merged 2 commits into from
Apr 5, 2024

Conversation

ReubenFrankel
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit c1c2ed0
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/660f2f16b4cb300008dc0916
😎 Deploy Preview https://deploy-preview-1727--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ReubenFrankel ReubenFrankel changed the title Add workflow to test Meltano add.install for changed plugins Add workflow to test Meltano add/install for changed plugins Mar 31, 2024
@ReubenFrankel ReubenFrankel reopened this Mar 31, 2024
@ReubenFrankel
Copy link
Contributor Author

@pnadolny13 @edgarrmondragon How can I enable this new workflow for testing?

@edgarrmondragon
Copy link
Collaborator

@pnadolny13 @edgarrmondragon How can I enable this new workflow for testing?

I think it has to be inmain before it starts running. Probably the best approach is to try it out on your fork.

@ReubenFrankel ReubenFrankel marked this pull request as ready for review April 4, 2024 22:52
@ReubenFrankel
Copy link
Contributor Author

OK, think this is ready for a review. You can check out example workflow runs from this test PR and this push.

@edgarrmondragon
Copy link
Collaborator

@ReubenFrankel should we update the title to reflect that this doesn't install the plugins?

@ReubenFrankel
Copy link
Contributor Author

@edgarrmondragon It does install:

- name: Test install
working-directory: test-project
run: meltano install

We can combine these into one step (i.e. meltano add without --no-install), if that is preferred.

@edgarrmondragon
Copy link
Collaborator

@edgarrmondragon It does install:

- name: Test install
working-directory: test-project
run: meltano install

We can combine these into one step (i.e. meltano add without --no-install), if that is preferred.

Oh gotcha, I missed that!. Makes sense to have them as separate steps :)

@edgarrmondragon edgarrmondragon merged commit 79240bd into meltano:main Apr 5, 2024
10 checks passed
@ReubenFrankel ReubenFrankel deleted the ci/test-meltano-add-install branch April 5, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants