Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-expand SDK settings detail section from link #1707

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Auto-expand SDK settings detail section from link #1707

merged 3 commits into from
Mar 15, 2024

Conversation

ReubenFrankel
Copy link
Contributor

From #1706:

I chose to collapse all SDK settings in both sections by default. The one downside I found is that if you click on one of the SDK settings in the first list it brings you down to the collapsed detailed SDK settings section but doesnt expand it for you. Not the worst but it would be ideal if it could automatically expand in that situation.

cc @pnadolny13

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit 92853c9
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/65f48fb9a3f88f00077cad99
😎 Deploy Preview https://deploy-preview-1707--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pnadolny13
Copy link
Contributor

@ReubenFrankel this is awesome! Thanks for fixing that.

@pnadolny13 pnadolny13 merged commit 7a8cfba into meltano:main Mar 15, 2024
10 checks passed
@ReubenFrankel ReubenFrankel deleted the auto-expand-sdk-settings-from-link branch March 15, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants