Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying additional path components in archiveCommitArtifacts #19

Open
remexre opened this issue Sep 27, 2021 · 1 comment
Open

Comments

@remexre
Copy link
Member

remexre commented Sep 27, 2021

Right now, whenever Silver builds a new commit, silver-ableC gets rebuilt too. When it runs melt.archiveCommitArtifacts("jars/*.jar"), this clobbers the previous JARs. The temporary solution I'm thinking of is storing silver-ableC artifacts as https://foundry.remexre.xyz/commit-artifacts/${silver-ableC-commit}/${silver-commit}/*.jar. Thoughts?

Aside: Is there a way to do O_EXCL for the copy?

@krame505
Copy link
Member

Oh sorry I overlooked this. That seems like a fine approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants