Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can one fall when there is no gravity? #478

Closed
wants to merge 1 commit into from
Closed

How can one fall when there is no gravity? #478

wants to merge 1 commit into from

Conversation

Deathspike
Copy link

Got around to forking and solving #291

@parasyte
Copy link
Collaborator

@Deathspike Hi! First, thanks for the patch. Before we merge this, can you explain how you discovered this behavior, and how is affects your game negatively?

@parasyte
Copy link
Collaborator

@Deathspike Sorry about the last message, please disregard! I see your reference to the other ticket, and I remember the issue. :) I'll recreate the commit, since we're no longer using tab characters.

@parasyte
Copy link
Collaborator

@Deathspike I committed a new patch that will disable the falling flag before it ever gets set. Can you test it and verify it works ok for your case?

@Deathspike
Copy link
Author

@parasyte Sorry for the tabs! The commit you made results in the same fixed behavior! Your solution is better though, as computeVelocity might be overridden by a user and therefore would could make the quick-patch I did earlier moot. +1

@parasyte
Copy link
Collaborator

Ok, closing these two!

@parasyte parasyte closed this Apr 10, 2014
@obiot obiot added this to the 1.0.1 milestone Apr 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants