Upgrade to Gradle 4.0 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this version would only be compatible with Gradle 4.0+ and Shadow plugin 2.0+. It makes use of the new worker API, which avoids us doing all the nasty jar repackaging of the runtime of JMH: a worker process is automatically spawned by Gradle with the appropriate classpath. This means that we can compile this plugin with a specific version of JMH, but the user can override the version, and we would still use the `Main` entry point instead of an exec task to execute the benchmarks. This commit also fixes the [warning issued by Gradle 4.0](#94), which is the main reason for broken compatibility with released under 4.0: the newer API doesn't exist on 3.5. This commit however breaks a test with the shadow plugin, and is waiting for the resolution of [this bug](GradleUp/shadow#297).
Signed-off-by: Cedric Champeau <[email protected]>
This was referenced Jun 24, 2017
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the plugin for compatibility with Gradle 4.0.