-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another take at a Tags domain #101
base: main
Are you sure you want to change the base?
Conversation
Also: this actually works without the |
Here's a pointer someone shared at the writethedocs slack: https://github.com/dernorberto/sphinxPageProperties/blob/main/extension/page_properties_report.py and also sphinx-doc/sphinx#11562 |
for more information, see https://pre-commit.ci
Co-authored-by: hannah <[email protected]>
This generates a couple of build warnings, because some references are missing on the first pass. This is expected, but we should either silence these errors or defer resolution of these references until later. This also doesn't include badges for similar reasons: because the references in the badges can't be resolved in the first pass, the badges are not linked to any pages.
I think this is almost there. A couple of details left, as mentioned in the commit message: This generates a couple of build warnings, because some references are This also doesn't include badges for similar reasons: because the references |
Not sure why the docs build is failing on readthedocs as I don't see this failure locally. Will investigate later. |
Here's an attempt at a domain approach - building on the idea by @story645. This is very similar to #92 but I am explicitly trying to do the bare minimum.
This works well to read and generate tags. The problem is:
Any tips are appreciated 🙏🏻