Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub and sup tags are not correctly aligned #76

Closed
todaywesleep opened this issue Jan 8, 2018 · 11 comments
Closed

Sub and sup tags are not correctly aligned #76

todaywesleep opened this issue Jan 8, 2018 · 11 comments
Labels
bug:upstream The bug is caused by a third party library. bug Crush'em all.

Comments

@todaywesleep
Copy link

How I can correct render and sub tags?
When I render sup task, text becoming common, and don't support textVerticalAlign: 'top', is always eat bottom. Any have issue?
@Exilz

This comment has been minimized.

Sign in to view
@Exilz Exilz added enhancement An enhancement is a change that is not a feature. is:help wanted We are welcoming PRs to address this. labels Jan 12, 2018
@brunoti

This comment has been minimized.

Sign in to view
@pllumh

This comment has been minimized.

Sign in to view
@saeedtkh

This comment has been minimized.

Sign in to view
@matteodanelli

This comment has been minimized.

Sign in to view
@jsamr

This comment has been minimized.

Sign in to view
@msfreit

This comment has been minimized.

Sign in to view
@jsamr jsamr added feature:upstream A feature which requires upstream changes to be implemented. and removed is:help wanted We are welcoming PRs to address this. labels Jul 19, 2020
@jsamr
Copy link
Collaborator

jsamr commented Jul 19, 2020 •
edited
Loading

This feature, to be fully implemented, requires React Native to support textAlignVertical: sub and textAlignVertical: super. As of React Native 0.63, those values are unsupported.
textAlignVertical: "top" and textAlignVertical: "bottom" style properties are only supported for Android, and as of version 0.63.3, do not work in nested Text instances. In the end, we do have a limited support for sub an sup, but only on Android.

jsamr added a commit that referenced this issue Jul 20, 2020
@jsamr
refactor: remove misleading sub and sup styles
002b7fb 
textAlignVertical doesn't work relatevely to line, but to containing
block. Those styles gave the false impression that sub and sup where
fully supported, but that will not be the case until React Native has
official support for this.

Vote for the feature here: https://react-native.canny.io/feature-requests/p/support-superscript-and-subscript

Related #259, #76
@jsamr jsamr mentioned this issue Jul 20, 2020
Closed
@kshitijsharma6325

This comment has been minimized.

Sign in to view
@jsamr

This comment has been minimized.

Sign in to view
@jsamr jsamr added bug Crush'em all. bug:upstream The bug is caused by a third party library. and removed enhancement An enhancement is a change that is not a feature. feature:upstream A feature which requires upstream changes to be implemented. new feature labels Jul 8, 2021
@jsamr jsamr changed the title Render sup and sub tags Sub and sup tags are not correctly aligned Jul 8, 2021
@jsamr
Copy link
Collaborator

jsamr commented Sep 24, 2021

I am closing because this issue has to be fixed upstream.

@jsamr jsamr closed this as completed Sep 24, 2021
@meliorence meliorence locked and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug:upstream The bug is caused by a third party library. bug Crush'em all.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@matteodanelli @jsamr @brunoti @pllumh @Exilz @msfreit @todaywesleep @saeedtkh @kshitijsharma6325