Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude Polyspace defects with status "Not a Defect" or "Justified"; Add substitution of env variables for min/max possible for Robot and Polyspace #143

Merged
merged 24 commits into from
Jul 25, 2024
Merged

Exclude Polyspace defects with status "Not a Defect" or "Justified"; Add substitution of env variables for min/max possible for Robot and Polyspace #143

merged 24 commits into from
Jul 25, 2024

Conversation

JokeWaumans
Copy link
Contributor

@JokeWaumans JokeWaumans commented Jul 25, 2024 •
edited
Loading

  • Exclude Polyspace defects with a status "Not a Defect" or "Justified"
  • Make it possible to use environment variables for min and max keys instead of numbers

@JasperCraeghs
Copy link
Member

JasperCraeghs commented Jul 25, 2024 •
edited
Loading

"If you do not plan to fix your code in response to a result, assign one of the following statuses:

  • Justified
  • No Action Planned
  • Not a Defect"

https://nl.mathworks.com/help/polyspace_access/ug/fix-or-comment-polyspace-results-web-browser.html

Please document these changes.

@JasperCraeghs JasperCraeghs requested a review from Letme July 25, 2024 11:22
Letme
Letme approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@Letme Letme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@JokeWaumans
Copy link
Contributor Author

"If you do not plan to fix your code in response to a result, assign one of the following statuses:

  • Justified
  • No Action Planned
  • Not a Defect"

https://nl.mathworks.com/help/polyspace_access/ug/fix-or-comment-polyspace-results-web-browser.html

Please document these changes.

Isn't "No Action Planned" a tricky one?
"If you do not explicitly specify a status in your annotation, Polyspace assumes that you have set a status of No Action Planned."

@Letme
Copy link
Member

Letme commented Jul 25, 2024

I would as well avoid adding default status in here indeed. So current implementation seems fine.

@JasperCraeghs JasperCraeghs self-assigned this Jul 25, 2024
@JokeWaumans JokeWaumans changed the title Exclude Polyspace defect when the status is "Not a defect" or "Justified" Exclude Polyspace defects with status "Not a defect" or "Justified"; Add substitution of env variables for min/max possible for Robot and Polyspace Jul 25, 2024
@JokeWaumans JokeWaumans changed the title Exclude Polyspace defects with status "Not a defect" or "Justified"; Add substitution of env variables for min/max possible for Robot and Polyspace Exclude Polyspace defects with status "Not a Defect" or "Justified"; Add substitution of env variables for min/max possible for Robot and Polyspace Jul 25, 2024
pietvr
pietvr reviewed Jul 25, 2024
View reviewed changes
README.rst Outdated Show resolved Hide resolved
JasperCraeghs
JasperCraeghs requested changes Jul 25, 2024
View reviewed changes
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
JokeWaumans and others added 6 commits July 25, 2024 16:06
@JokeWaumans @JasperCraeghs
Rephrase
b86dbb6 
Co-authored-by: Jasper Craeghs <[email protected]>
@JokeWaumans
Rephrase README
bd2ee46
@JasperCraeghs
Revert "Fix over-indented"
6e8cb8d 
This reverts commit deecdd1.
@JasperCraeghs
Revert "Make substitution of environment variables possible for min a…
ff64d74 
…nd max of different checker of Polyspace and Robot"

This reverts commit 0b4eb2a.
@JasperCraeghs
Revert "Revert "Make substitution of environment variables possible f…
59b1209 
…or min and max of different checker of Polyspace and Robot""

This reverts commit ff64d74.
@JasperCraeghs
Revert implementation part of 0b4eb2a
4923b47
@JasperCraeghs JasperCraeghs merged commit a561a37 into master Jul 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietvr pietvr pietvr left review comments

@JasperCraeghs JasperCraeghs JasperCraeghs approved these changes

@Letme Letme Letme approved these changes

Assignees

@JokeWaumans JokeWaumans

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JokeWaumans @JasperCraeghs @Letme @pietvr