Implement Polyspace checker #142

JokeWaumans · 2024-06-26T09:52:41Z

Closes #140

…specified in config

… check value

This reverts commit acd80d1.

docs/design.rst

src/mlx/warnings/polyspace_checker.py

src/mlx/warnings/warnings.py

src/mlx/warnings/warnings_checker.py

.gitignore

…n into polyspace-checker

Co-authored-by: Jasper Craeghs <[email protected]>

README.rst

…y Report"

…n JSON of README to fix red color

…eadme" This reverts commit f9ad210.

…and update tests

README.rst

Co-authored-by: Jasper Craeghs <[email protected]>

Letme

Minor typo remarks. Not sure they are really valid.

README.rst

Co-authored-by: Crt Mori <[email protected]>

JokeWaumans added 9 commits June 13, 2024 17:40

Update class diagram

d181c3f

Update config files with code_prover and bug_finder

9ff1e18

Add first changes to add BugFinderChecker and CodeProverChecker

43566cd

Start implementing PolyspaceChecker with different checkers for each …

681840a

…specified in config

Add polyspace checker with different checker for each column name and…

5e29ef3

… check value

Read the file once; loop over checkers

0a0004e

Fix typo

5d98602

Add **kwargs to check()

86eb3f4

Add tests for polyspace; update config files with polyspace

e67facd

JokeWaumans requested a review from JasperCraeghs June 26, 2024 09:52

JokeWaumans assigned Letme Jun 26, 2024

JokeWaumans added 6 commits June 26, 2024 12:02

Fix flake8

0a397a9

Add test with csv file (code prover)

7776426

Add test case for bug finder

eb04028

Remove --polyspace argument

605ae69

Make PolyspaceCheck inherit from Warningschecker

8b58040

Add testcases with dummy files (code prover and bug finder combined)

64e7da6

JokeWaumans changed the title ~~Draft: Implement Polyspace checker~~ Implement Polyspace checker Jun 26, 2024

JokeWaumans changed the title ~~Implement Polyspace checker~~ Draft: Implement Polyspace checker Jun 26, 2024

JokeWaumans added 9 commits June 27, 2024 16:28

Add code quality findings for polyspace

a70e08a

Use pythonic getter/setter: minimum and maximum property with setter

7a61b26

Add test for code quality of polyspace

a1d7b35

Update gitignore

be2df62

Add correct severity

078f5e1

Update severity in code quality JSON file to test with

3f8da67

Simplify the configuration file of polyspace

c828bfd

Add some debug prints

acd80d1

Revert "Add some debug prints"

d340b2c

This reverts commit acd80d1.

JasperCraeghs requested changes Jul 1, 2024

View reviewed changes

Rename PolyspaceCheck to PolyspaceFamilyChecker

b631fc2

JokeWaumans and others added 8 commits July 4, 2024 17:11

Merge branch 'polyspace-checker' of github.com:melexis/warnings-plugi…

621357b

…n into polyspace-checker

Use self.__class__.__name__ instead of hardcoded class name

210b180

Rephrase sentence

26cc0ed

Co-authored-by: Jasper Craeghs <[email protected]>

Rename subtitle

9ca41b2

Co-authored-by: Jasper Craeghs <[email protected]>

Fix syntax

63a89b5

Co-authored-by: Jasper Craeghs <[email protected]>

Delete tabs

67ed4f6

Co-authored-by: Jasper Craeghs <[email protected]>

Update the documentation about the default cq template

1cb7be2

Co-authored-by: Jasper Craeghs <[email protected]>

Rephrase sentence

48647aa

JasperCraeghs reviewed Jul 4, 2024

View reviewed changes

README.rst Outdated Show resolved Hide resolved

JokeWaumans added 7 commits July 4, 2024 17:25

Delete "Default Description Template"; it's mentioned in "Code Qualit…

ca76843

…y Report"

Fix link to section title

25e465c

Add missing comma

dd51f6c

Test with JSON config with removed \ from regex; Delete backslashes i…

98ca303

…n JSON of README to fix red color

Document that Line and Col are new columns in Polyspace version R2024a

aee25d0

Revert "Add -key-mode function-scope to polyspace-results-export in r…

a2724d0

…eadme" This reverts commit f9ad210.

Use ligitimate escape backslash

172b42d

JokeWaumans changed the title ~~Draft: Implement Polyspace checker~~ Implement Polyspace checker Jul 5, 2024

JokeWaumans added 3 commits July 5, 2024 10:44

Add documentation about how the fingerprint is made for Polyspace

87d133d

Update exclude regex to .+\tdummy_function\(\)\tdummy_file_name\.c\t …

a3a571c

…and update tests

Add clarification about exclude for polyspace

76f337f

JasperCraeghs reviewed Jul 5, 2024

View reviewed changes

README.rst Outdated Show resolved Hide resolved

JasperCraeghs reviewed Jul 5, 2024

View reviewed changes

README.rst Outdated Show resolved Hide resolved

JokeWaumans and others added 3 commits July 5, 2024 15:15

Add Polyspace to sentence in code quality report

9759d61

Set enable of Polyspace to true in example

4452742

Co-authored-by: Jasper Craeghs <[email protected]>

Rephrase documentation about exclude patterns

b43e257

Co-authored-by: Jasper Craeghs <[email protected]>

JasperCraeghs approved these changes Jul 5, 2024

View reviewed changes

Letme approved these changes Jul 5, 2024

View reviewed changes

README.rst Outdated Show resolved Hide resolved

README.rst Outdated Show resolved Hide resolved

README.rst Outdated Show resolved Hide resolved

JokeWaumans and others added 2 commits July 5, 2024 15:42

Add "yet" to sentence in documentation

8f3a5c1

Co-authored-by: Crt Mori <[email protected]>

Fix minor typo remarks

c38bbc6

Co-authored-by: Crt Mori <[email protected]>

JasperCraeghs merged commit 2831527 into master Jul 5, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Polyspace checker #142

Implement Polyspace checker #142

JokeWaumans commented Jun 26, 2024

Letme left a comment

Implement Polyspace checker #142

Implement Polyspace checker #142

Conversation

JokeWaumans commented Jun 26, 2024

Letme left a comment

Choose a reason for hiding this comment