Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update requirements + convention #100

Closed
wants to merge 1 commit into from

Conversation

spartanz51
Copy link

Added "rich" dependency (version 13.5.3) to the requirements.txt file

Additionally, I renamed the reqs.txt file to requirements.txt, aimed at following the widely accepted convention in the Python community, to minimize inconsistencies across repositories, especially within the SD Nodes/models ecosystem, which is sorely lacking in standards :)

@spartanz51 spartanz51 requested a review from melMass as a code owner September 22, 2023 23:23
@melMass
Copy link
Owner

melMass commented Sep 23, 2023

Hi,

Thanks for the suggestions but I will change most of this soonish.
There is a reason I'm not using "requirements.txt" as Comfy Manager detect and install the requirements.txt but because of some issues on windows (especially comfy portable) I need to bundle wheels (the ones referenced in reqs-win.txt) so I cannot only rely on pip markers, that's what I was doing before.
My idea is to remove these dependencies by default on windows and add a way to diagnose and install potential missing requirements later in the ui at /mtb

Rich and rich_argparse are only used in the scripts that aren't used by the nodes, but I could add instructions to pip install rich

@melMass melMass added this to the Release of v0.2.0 milestone Oct 5, 2023
@melMass melMass closed this in 5dfea51 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants