Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add medical supply order type flow to the order basket #1

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

vasharma05
Copy link
Member

@vasharma05 vasharma05 commented Nov 29, 2024

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

This PR adds a new order type to the Ozone HSC Implementation: Medical supply order.

Medical supply orders uses the Materials Concept class, along with supporting 2 additional properties to the Order, i.e. Quantity and Quantity units.

The Medical supply order panel is attached to the order basket as an extension and follows the usual flow as of the other present order types.

Screenshots

Screen.Recording.2024-12-13.at.14.57.58.mov

Related Issue

None

Other

Steps to run

yarn start --backend https://oz-hsc-dev.mekomsolutions.net --config-url /openmrs/spa/configs/ozone-frontend-config.json

@vasharma05
Copy link
Member Author

The build is failing because the patient common lib it's referencing is updated and not yet merged, hence this PR is dependent on the PR mentioned in the description.
Thanks!

@usamaidrsk
Copy link
Member

usamaidrsk commented Dec 12, 2024

Hi @vasharma05
Could please add some screenshots or video recording. Plus adding more description on your README.
Also an update on the PR description, how I could test the PR

Thanks

@vasharma05
Copy link
Member Author

Hi @usamaidrsk!
The PR description along with the screenshots and steps to run the project is shared as requested.
Thanks!

Copy link
Member

@usamaidrsk usamaidrsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @vasharma05
You should consider adding the translations too
Thanks

@vasharma05
Copy link
Member Author

Hi @rbuisson, please grant @usamaidrsk with the right access.
Thanks!

@vasharma05 vasharma05 merged commit d2c5c5f into main Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants